Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PartakingStateSelection query for rotational options #624

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

daanboer
Copy link
Contributor

@daanboer daanboer commented Dec 12, 2023

Currently, the query used by the cross section picker does not correctly retrieve the latex representation of rotational state descriptors. Instead it returns null values.

@daanboer daanboer enabled auto-merge (squash) December 12, 2023 13:16
Copy link

codecov bot commented Dec 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b502aa1) 87.15% compared to head (6eb3288) 87.15%.
Report is 31 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #624   +/-   ##
=======================================
  Coverage   87.15%   87.15%           
=======================================
  Files         106      106           
  Lines        7149     7149           
  Branches      476      476           
=======================================
  Hits         6231     6231           
  Misses        918      918           
Flag Coverage Δ
app 93.44% <ø> (ø)
database 84.54% <100.00%> (ø)
schema 94.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@daanboer daanboer merged commit a556a42 into main Dec 12, 2023
@daanboer daanboer deleted the select-rotational branch December 12, 2023 13:22
@daanboer daanboer added bug Something isn't working database labels Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working database
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant