Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for Flickr API authentication and also added FLICKR_SETS_INCLUDE #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

allanscullion
Copy link

The standard flickrapi code will only pull down 10 photo sets and the photos included in those sets seem restricted. I have added code to handle standard Flickr API authentication. All you have to do is include the API Secret in the settings. You get a one time authentication web page. You are then prompted to press ENTER to continue.

I have also added a FLICKR_SETS_INCLUDE setting. This take precedence over the EXCLUDE counterpart and allows the user to choose the photo sets they want to include.

@La0
Copy link
Owner

La0 commented Oct 14, 2014

Hi allan,

Thanks a lot for your pull request.
I have worked a while ago on a branch handling auth to generate private pages for my private photos.
You can see my work on the auth branch (it was not online before because i didn't totally finish it... and kind of forgot it :/)

Maybe you could rebase your work on this branch, i would merge everything in master then.

@allanscullion
Copy link
Author

Hi,

It looks like in the main, your changes in the auth branch cover the OAuth authentication changes that I made. The only missing part is the code to handle FLICKR_SETS_INCLUDE. When I get some time, I will test out the auth branch and rebase the changes as advised.

Thanks for the great work btw ;)

Cheers
Allan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants