fix partial match for non dictionary items #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jafaral
force-pushed
the
fix-partial-match
branch
4 times, most recently
from
97bde0d to
33444e8
Compare
currenlty with partial match `[{"foo":"foo"}]` is considered a subset of
`[{"foo":"foo"}, {"bar":"bar"}]`. However `[1]` is not considered a subset
of `[1,2]`. This fixes the behavior so that partial match rules apply
to non dictionary items within a list.
Signed-off-by: Jafar Al-Gharaibeh <[email protected]>
Jafaral
force-pushed
the
fix-partial-match
branch
from
33444e8 to
6254f8d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #47 +/- ##
==========================================
- Coverage 59.98% 58.84% -1.14%
==========================================
Files 19 19
Lines 5665 5730 +65
==========================================
- Hits 3398 3372 -26
- Misses 2267 2358 +91 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currenlty with partial match
[{"foo":"foo"}]is considered a subset of[{"foo":"foo"}, {"bar":"bar"}]. However[1]is not considered a subset of[1,2]. This fixes the behavior so that partial match rules apply to non dictionary items within a list.