Merge pull request #138 from Jeshibu/master

Removed expensive calls from game menu item creation
Lacro59 · Sep 12, 2021 · 0ea6615 · 0ea6615
2 parents 164affd + 5f96c19
commit 0ea6615
Show file tree

Hide file tree

Showing 2 changed files with 39 additions and 3 deletions.
diff --git a/source/Services/SuccessStoryDatabase.cs b/source/Services/SuccessStoryDatabase.cs
@@ -755,6 +755,42 @@ public AchievementsGraphicsDataCount GetCountByDay(Guid? GameID = null, int limi
             return new AchievementsGraphicsDataCount { Labels = GraphicsAchievementsLabels, Series = SourceAchievementsSeries };
         }
 
+        public static bool GameCouldHaveAchievements(SuccessStorySettings settings, string GameSourceName, string GameName)
+        {
+            switch (GameSourceName.ToLower())
+            {
+                case "playstation":
+                    return settings.EnablePsn;
+                case "steam":
+                    return settings.EnableSteam;
+                case "gog":
+                    return settings.EnableGog;
+                case "origin":
+                    return settings.EnableOrigin;
+                case "xbox":
+                    return settings.EnableXbox;
+                case "playnite":
+                case "hacked":
+                    return settings.EnableLocal;
+                case "retroachievements":
+                    return settings.EnableRetroAchievements;
+                case "rpcs3":
+                    return settings.EnableRpcs3Achievements;
+                case "battle.net":
+                    switch (GameName.ToLower())
+                    {
+                        case "overwatch":
+                            return settings.EnableOverwatchAchievements;
+                        case "starcraft 2":
+                        case "starcraft ii":
+                            return settings.EnableSc2Achievements;
+                    }
+                    break;
+            }
+
+            return false;
+        }
+
 
         /// <summary>
         /// 

diff --git a/source/SuccessStory.cs b/source/SuccessStory.cs
@@ -305,14 +305,14 @@ public override IEnumerable<GameMenuItem> GetGameMenuItems(GetGameMenuItemsArgs
             string SourceName = PlayniteTools.GetSourceName(PlayniteApi, GameMenu);
             string GameName = GameMenu.Name;
             bool IsAddOrShowManual = SuccessStoryDatabase.IsAddOrShowManual(GameMenu, SourceName);
-            bool VerifToAddOrShow = SuccessStoryDatabase.VerifToAddOrShow(this, PlayniteApi, PluginSettings.Settings, this.GetPluginUserDataPath(), SourceName, GameName);
+            bool GameCouldHaveAchievements = SuccessStoryDatabase.GameCouldHaveAchievements(PluginSettings.Settings, SourceName, GameName);
             GameAchievements gameAchievements = PluginDatabase.Get(GameMenu, true);
 
             List<GameMenuItem> gameMenuItems = new List<GameMenuItem>();
 
             if (!gameAchievements.IsIgnored)
             {
-                if (VerifToAddOrShow || IsAddOrShowManual)
+                if (GameCouldHaveAchievements || IsAddOrShowManual)
                 {
                     if (!PluginSettings.Settings.EnableOneGameView || (PluginSettings.Settings.EnableOneGameView && gameAchievements.HasData))
                     {
@@ -451,7 +451,7 @@ public override IEnumerable<GameMenuItem> GetGameMenuItems(GetGameMenuItemsArgs
             }
             else
             {
-                if (VerifToAddOrShow || IsAddOrShowManual)
+                if (GameCouldHaveAchievements || IsAddOrShowManual)
                 {
                     gameMenuItems.Add(new GameMenuItem
                     {