LibWeb: Implement valueAsNumber for month and week <input> element types #3485
+455
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These can be useful outside of the scope of the function these are used.
This is intended to be used by the <input> element 'week' type state and convert that to milliseconds from the Unix epoch (ignoring leap seconds). I am certain there is a much better way of writing this that does not need a loop, but I am less convinced about writing that without running into some edge case I didn't consider.
One point to note is that I am not entirely sure what the result of the pre-existing valueAsNumber test should be for this strange case which does not lie exactly on a week/day boundary. Chrome gives a negative timestamp, which seems more wrong than the result we give, and neither gecko or WebKit appear to support the 'week' type. So I'm considering this result acceptable for now, and this may be something that will need more WPT tests added in the future.
shannonbooth
force-pushed
the
week-format
branch
from
4860bc9 to
a0a3eb2
Compare
trflynn89
reviewed
Feb 8, 2025
|
|
||
| u32 number_of_months_since_unix_epoch(YearAndMonth year_and_month) | ||
| { | ||
| return (year_and_month.year - 1970) * 12 + year_and_month.month - 1; |
There was a problem hiding this comment.
What happens if the year is 1969? Seems like this should return a signed result?
There was a problem hiding this comment.
oops, yeah this is wrong, I'll submit a MR to WPT to add a test for this case. It's also incorrect on the setter side to use fmod as that also doesn't handle the signed case, should instead be something like JS::modulo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.