LibGfx/PNG: Add support for the cICP chunk #3502
Open
+133
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trflynn89
reviewed
Feb 8, 2025
This introduces a new API in ImageDecoderPlugins that allow an image decoder to return a CICP struct. Also, we use this API in ImageDecoder::color_space() to create a color space corresponding to these CICP.
|
Oh, looks like I need to set up the commit hooks on my laptop.
Thanks, I really thought that it would be a small and easy PR, it turned out to be a whole experience. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First patch set toward fixing #3498. I left a few fixme in the code (like supporting more points) and also I wasn't able to import the test from the issue (but the two others cicp-related tests were fine).
I'll try to fix both the importer issue and adding support fore more code points when I come back in a few days.