-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Remove redundant words #3503
base: master
Are you sure you want to change the base?
Conversation
Hello! One or more of the commit messages in this PR do not match the Ladybird code submission policy, please check the |
@@ -659,7 +659,7 @@ WebIDL::ExceptionOr<GC::Ref<Element>> create_element(Document& document, FlyStri | |||
element->set_is_value(move(is_value)); | |||
element->set_custom_element_state(CustomElementState::Uncustomized); | |||
|
|||
// 3. If namespace is the HTML namespace, and either localName is a valid custom element name or is is non-null, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one is not a typo. That is is a variable name, as you can see in the spec this comes from: https://dom.spec.whatwg.org/#concept-create-element
@@ -5428,7 +5428,7 @@ GC::Ptr<Element const> Document::scrolling_element() const | |||
// 1. If the Document is in quirks mode, follow these substeps: | |||
if (in_quirks_mode()) { | |||
// 1. If the body element exists, and it is not potentially scrollable, return the body element and abort these steps. | |||
// For this purpose, a value of overflow:clip on the the body element’s parent element must be treated as overflow:hidden. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one is, for better or for worse, also a spec typo / oddity: https://drafts.csswg.org/cssom-view/#dom-document-scrollingelement
You should probably open the PR there first.
The lint-script doesn't auto detect it, but |
remove redundant words