Make ::marker pseudo-elements inspectable without crashing
#3529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We only cache pseudo-element computed style for ::before and ::after currently, so avoid dereferencing a null ComputedProperties pointer.
This allows us to inspect its properties. To avoid wasted work, we only compute and cache the properties if the originating element was, or is, displaying as a list item.
We can't simply walk the element tree and pass in `pseudo_element` each time. Instead, we want to look at: 1. Element's pseudo-element 2. Element 3. Element's parents
|
Aaand another commit because I noticed that the custom properties table for pseudo-elements was missing some entries. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2432.
Just to demonstrate, here's me inspecting a
::markerwithcolor: orangeset on it, and seeing that show up in the inspector. (It's hard to see the actual orange colour because of the highlight but it is there I promise. 😆 )I believe
::markeris the only generated pseudo-element that did not already have its computed style cached, so this shouldn't affect any other pseudo-elements. However, to avoid such crashes, I've changed the inspection code to print a debug message instead of trying to deref a null ComputedProperties pointer.