Av old hyrax #1130
Av old hyrax #1130
Conversation
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| require 'digest/md5' | ||
| require 'fileutils' | ||
|
|
||
| module Spot |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
| require 'digest/md5' | ||
| require 'fileutils' | ||
|
|
||
| module Spot |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
jwellnit
force-pushed
the
av-old-hyrax
branch
from
d924ad0 to
a0802a3
Compare
|
Code Climate has analyzed commit d6dc02f and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 86.4% (100% is the threshold). This pull request will bring the total coverage in the repository to 97.6%. View more on Code Climate. |
jwellnit
force-pushed
the
av-old-hyrax
branch
2 times, most recently
from
8a30e5a to
52826be
Compare
app/helpers/audio_visual_helper.rb
Outdated
| return "" | ||
| end | ||
| client_opts = {} | ||
| client_opts = { endpoint: ENV['AWS_ENDPOINT_URL']&.sub('minio', 'localhost') } if Rails.env.development? |
There was a problem hiding this comment.
try pulling out the & after ENV['AWS_ENDPOINT_URL'] to fix coverage? since you're already testing to see if it's empty above, you don't need to assume it might not be there at this point
jwellnit
force-pushed
the
av-old-hyrax
branch
from
eccb206 to
cfbf0f4
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1130 +/- ##
===========================================
+ Coverage 98.56% 98.75% +0.19%
===========================================
Files 177 192 +15
Lines 3059 3368 +309
===========================================
+ Hits 3015 3326 +311
+ Misses 44 42 -2
|
Add audio visual work type and associated back-end support