Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release 2019.5 #334

Merged
merged 5 commits into from
Nov 11, 2019
Merged

release 2019.5 #334

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6004fda
update Publication#resource_type to allow {0,n} inputs
rococodogs Nov 11, 2019
df50c2d
expand min-height of select[multiple] inputs
rococodogs Nov 11, 2019
002eb59
Merge pull request #333 from LafayetteCollegeLibraries/bugfix/resourc…
rococodogs Nov 11, 2019
06f4c2a
add error handling for .txt + .json formats (#335)
rococodogs Nov 11, 2019
a6feb65
update changelog for 2019.5
rococodogs Nov 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions app/assets/stylesheets/spot.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,3 +75,7 @@
overflow: visible !important;
padding-bottom: 0;
}

select[multiple] {
rococodogs marked this conversation as resolved.
Show resolved Hide resolved
min-height: 15rem;
}
1 change: 0 additions & 1 deletion app/forms/hyrax/publication_form.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,6 @@ def singular_terms
abstract
date_issued
date_available
resource_type
title
]
end
Expand Down
2 changes: 1 addition & 1 deletion spec/forms/hyrax/publication_form_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@

describe '.multiple?' do
it 'marks singular fields as false' do
%w[resource_type abstract issued available date_created title].each do |f|
%w[abstract issued available date_created title].each do |f|
expect(described_class.multiple?(f)).to be false
end
end
Expand Down