2019.7 #348
Merged
2019.7 #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* update pdfjs to latest release * use version no. in filename to not use old cached version
* store/index local + standard identifiers separately * update publication_presenter/solr_document to use solr std/local ids
houndci-bot
reviewed
Nov 18, 2019
|
as with #346, we're ignoring @houndci-bot's suggestions for the PDF.js javascript |
|
Code Climate has analyzed commit 6dfe8f2 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (100% is the threshold). This pull request will bring the total coverage in the repository to 98.1% (0.0% change). View more on Code Climate. |
* add date_issued validation for Publications * update other specs to include required date_issued field * add required fields to publication_form, move them to the top * remove unneccessary :fields param for publication validation * switch to using factories on batch_edit_form_spec * add inclusion validation for rights_statement + resource_type * rubo + spec fixes * use oclc's FAST subject headings for :subject * update specs for controlled subject field * update locales for controlled fields * explicitly require equivalent-xml's matchers somehow this broke? the gem's github issues pointed towards explicitly requiring the matchers to get things working. * fix specs involving subject
* remove Spot::CollectionFromConfig service * remove collection creation task
* apply date_available via actor_stack * remove date_available from the publication form
we want to prevent a reindex of until the blacklight-oai integration lands, so that we only need to run one reindex instead of two (semi) back-to-back.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
features 💡
robots.txtfile to block archive.org from crawling our works as we don't want to fill up our diskspace quota with access copies of materials (a657879)rather than relying on a presenter to split them out(Index split identifiers #347)date_issued,resource_type, andrights_statementdate_issued,resource_type, andrights_statementare now required fields on the formdate_issuedhelp text (requires YYYY-MM or YYYY-MM-DD)subjectsidekiq-cron(add service/job to clear expired embargoes + leases #355)date_availablevia thePublicationActor, instead of the form. takes into account embargoes when present (Publication#date_available modifications #356)dependencies 👩👩👧👧
linkeddatagem to allow integration of OCLC's FAST subject heading service (publication enhancements 🔧 #350)bug fixes 🐞
docker-compose.ymlandconfig/initializers/okcomputer.rb(cd75393)deprecations ☠️
Spot::CollectionFromConfigservice to prevent inadvertently changing live collections (Remove CollectionFromConfig service #354)date_availablefromPublicationForm(Publication#date_available modifications #356)notes 🗒
this will require a reindex, as Index split identifiers #347 removes the previous identifier key in favor ofpushing off reindexing until add blacklight_oai_provider #323 landsidentifier_local_ssimandidentifier_standard_ssimcloses #309
closes #338
closes #343
closes #344
closes #345
closes #349
closes #352
closes #353