Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

public metadata-only record display for embargo/authenticated items #701

Closed
wants to merge 26 commits into from

Conversation

rococodogs
Copy link
Member

@rococodogs rococodogs commented Feb 18, 2021

  • adds 'public' to a work's #discover_groups array if its visibility is anything besides 'private'.
  • allows embargoed works to have a visibility of 'public' during the embargo (but still restrict file access to admins)

closes #698

@rococodogs rococodogs marked this pull request as ready for review February 23, 2021 16:53
@rococodogs rococodogs changed the title wip: public metadata-only record display for embargo/authenticated items public metadata-only record display for embargo/authenticated items Feb 23, 2021
@rococodogs
Copy link
Member Author

after testing some variations to confirm this was working as expected, it turns out it's not and may require adding a visibility setting for metadata-only. gonna close this out, cherry-pick some of the enhancements into their own pr's, and start over with a fifth visibility option.

@rococodogs rococodogs closed this Feb 24, 2021
This was referenced Feb 24, 2021
rococodogs added a commit that referenced this pull request Feb 26, 2021
rococodogs added a commit that referenced this pull request Mar 19, 2021
* add metadata-only visibility to our models

* add specs

* first pass @ porting view labels from #701

* typo fixes and cleanup

* 2 complex 4 rubo

* helper specs

* we need to enforce html_safe in the helper

* some refactoring / make private things undiscoverable

* ensure authenticated items are discoverable

* fix + spec hyrax/permission_badge modification

* improve SolrDocument#visibility

* a little refactoring

* regenerate thumbnails after clearing embargos/leases

* remove embargo/lease info from catalog_controller index fields

* cleanup catalog_helper_spec
@rococodogs rococodogs deleted the feature/metadata-only-records branch January 31, 2023 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant