Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get collections partials to work with admin_sets #830

Merged
merged 1 commit into from
Feb 3, 2022

Conversation

rococodogs
Copy link
Member

  • adds guard clauses to hyrax/collections/_collection_description partial for custom collection_presenter fields not shared with Hyrax::AdminSetPresenter
  • uses the @presenter instance variable in hyrax/collections/_show_descriptions partial to prevent a conflict with a similarly named blacklight helper method

closes #829

@codeclimate
Copy link

codeclimate bot commented Feb 3, 2022

Code Climate has analyzed commit cb79e11 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (100% is the threshold).

This pull request will bring the total coverage in the repository to 97.9% (0.0% change).

View more on Code Climate.

@rococodogs rococodogs merged commit 6b719ff into develop Feb 3, 2022
@rococodogs rococodogs deleted the bugfix/admin-admin_set-show branch February 3, 2022 18:22
@rococodogs rococodogs mentioned this pull request Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant