Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new icon #989

Open
wants to merge 1 commit into
base: primary
Choose a base branch
from
Open

new icon #989

wants to merge 1 commit into from

Conversation

jwellnit
Copy link
Collaborator

Changed laf visibility icon to:
lafaytte-2
Other options are:
eye-1
eye-2
lafaytte-1

@jwellnit jwellnit self-assigned this Jan 27, 2023
@jwellnit jwellnit linked an issue Jan 27, 2023 that may be closed by this pull request
@codeclimate
Copy link

codeclimate bot commented Jan 27, 2023

Code Climate has analyzed commit aa42956 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (100% is the threshold).

This pull request will bring the total coverage in the repository to 97.8% (0.0% change).

View more on Code Climate.

@noraegloff
Copy link
Contributor

Personally I like these ones, because they match the red of the site banner:

redEye

LafayetterBanner

But that's a somewhat minor detail. @rococodogs what do you think?

@rococodogs
Copy link
Member

Screenshot 2023-02-01 at 7 27 51 AM

I spoofed both options into the catalog to give us an idea of what they'll look like IRL. I'm with @noraegloff about the color (I like how it syncs with the header bar). I think I'm leaning towards the name vs the eye as far as design.

@rococodogs rococodogs force-pushed the develop branch 2 times, most recently from f9aaabf to 176bcfb Compare September 6, 2023 13:25
Base automatically changed from develop to primary October 30, 2023 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

different thumbnail for lafayette-only visibility?
3 participants