Add FinalizationRegistry impl #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LanderlYoung
force-pushed
the
finalizer_registry
branch
5 times, most recently
from
734b4f4 to
8c745d2
Compare
LanderlYoung
changed the title
LanderlYoung
force-pushed
the
finalizer_registry
branch
from
8c745d2 to
2dc6a8a
Compare
LanderlYoung
force-pushed
the
finalizer_registry
branch
9 times, most recently
from
b0664aa to
c92cff6
Compare
LanderlYoung
commented
Aug 1, 2024
LanderlYoung
changed the title
LanderlYoung
force-pushed
the
finalizer_registry
branch
8 times, most recently
from
eb395b0 to
801dd06
Compare
LanderlYoung
force-pushed
the
finalizer_registry
branch
from
d48e6a8 to
991164a
Compare
LanderlYoung
force-pushed
the
refactor_hash_map
branch
2 times, most recently
from
affbd87 to
8b6bb69
Compare
LanderlYoung
force-pushed
the
finalizer_registry
branch
2 times, most recently
from
4391fb1 to
08b4f1e
Compare
LanderlYoung
force-pushed
the
refactor_hash_map
branch
from
8b6bb69 to
717cb70
Compare
LanderlYoung
force-pushed
the
finalizer_registry
branch
from
08b4f1e to
1990f06
Compare
LanderlYoung
force-pushed
the
refactor_hash_map
branch
from
717cb70 to
ab9f568
Compare
LanderlYoung
changed the title
LanderlYoung
force-pushed
the
finalizer_registry
branch
from
1990f06 to
2adb107
Compare
LanderlYoung
force-pushed
the
refactor_hash_map
branch
5 times, most recently
from
fd54841 to
50ca57c
Compare
LanderlYoung
force-pushed
the
finalizer_registry
branch
3 times, most recently
from
bda6759 to
cdee815
Compare
LanderlYoung
changed the base branch from
refactor_hash_map
to
linked_hash_map_for_map
LanderlYoung
force-pushed
the
linked_hash_map_for_map
branch
from
54f7248 to
a71f94c
Compare
LanderlYoung
force-pushed
the
finalizer_registry
branch
3 times, most recently
from
7e4388f to
99d2359
Compare
LanderlYoung
force-pushed
the
linked_hash_map_for_map
branch
2 times, most recently
from
eaa1d68 to
60ff781
Compare
LanderlYoung
force-pushed
the
finalizer_registry
branch
2 times, most recently
from
ad3b51f to
42b2fd3
Compare
LanderlYoung
force-pushed
the
linked_hash_map_for_map
branch
from
60ff781 to
3ec4080
Compare
1. cleanupCallback is invked by a job (JS_EnqueueJob) 2. registries are stored in JSContext for manage and perform clanup callback 3. ensure related jobs are cancled when JSContext release.
LanderlYoung
force-pushed
the
finalizer_registry
branch
from
42b2fd3 to
381b43f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To implement
FinalizationRegistry, there are some problems that need to be answered.cleanupCallbackduring target finalization.JSContextmay be GCed before the target object.