Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use blank layout #119

Merged
merged 7 commits into from
Apr 11, 2023
Merged

Use blank layout #119

merged 7 commits into from
Apr 11, 2023

Conversation

tabacitu
Copy link
Member

@tabacitu tabacitu commented Apr 5, 2023

WHY

BEFORE - What was wrong? What was happening before this PR?

We were using top_left layout, which didn't include the ability to add Widgets.

AFTER - What is happening after this PR?

We are using blank which does.

tabacitu and others added 6 commits April 5, 2022 08:27
…nfig-file

Revert "removed v3 config file in order to work with any version of spatie/laravel-backup"
…emove-v3-config-file

Revert "Revert "removed v3 config file in order to work with any version of spatie/laravel-backup""
@tabacitu
Copy link
Member Author

tabacitu commented Apr 5, 2023

@pxpm what's with this other change in BackupController... is this actually needed? It's a red flag for me because I see it's been done, reverted, done, reverted 😅 But I don't remember us doing that... do you?

@tabacitu tabacitu merged commit 240ff3f into master Apr 11, 2023
@tabacitu tabacitu deleted the use-blank-layout branch April 11, 2023 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants