Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added swedish translation #131

Merged
merged 1 commit into from
Sep 3, 2024
Merged

Conversation

SoloOrchid
Copy link
Contributor

WHY

BEFORE - What was wrong? What was happening before this PR?

there was no Swedish language support

AFTER - What is happening after this PR?

the package is not more user friendly wish Swedish translation

HOW

How did you achieve that, in technical terms?

all i really did was create a new folder for the Swedish language and then translated the english strings from the english file

Is it a breaking change or non-breaking change?

no its not breaking anything

How can we test the before & after?

that can be done by changing the localization of the application

Copy link

welcome bot commented Sep 3, 2024

BOOM! Your first PR with us, thank you so much! Someone will take a look at it shortly.
Please keep in mind that:

  • if this constitutes a breaking change, it might take quite a while for this to get merged; we try to emulate the Laravel release cycle as much as possible, so developers can upgrade both software once; this means a new big release every ~6 months;
  • even if it's a non-breaking change, it might take a few days/weeks for the PR to get merged; unless it's a no-brainer, we like to have some community feedback on new features, before we merge them; this leads to higher-quality code, in the end; we learnt this the hard way :-)
  • not all PRs get merged; sometimes we just have to hold out new features, to keep the packages lean; sometimes we don't include features that only apply to niche use cases;
  • we're not perfect; if you think we're wrong, call us out on it; but in a kind way :-) we all make mistakes, best we learn from them and build better software together;

Thank you!
-- Justin Case The Backpack Robot

@SoloOrchid
Copy link
Contributor Author

this is the PR that ive written for the swedish language
#130

@pxpm
Copy link
Contributor

pxpm commented Sep 3, 2024

Thanks @SoloOrchid

My Swedish is a little bit rusty, but I trust you! hehe 🙏

Thanks for taking time to submit the PR! Much appreciated. If you want to help translating/completing other package Swedish language files, backpack/crud may need some update 🙏

Cheers

@pxpm pxpm merged commit 901253d into Laravel-Backpack:main Sep 3, 2024
1 of 2 checks passed
Copy link

welcome bot commented Sep 3, 2024

WHOOP-WHOOP! Congrats, your first PR on this repo has officialy been merged.
party
If you want to help out the community in other ways, you can:

  • give your opinion on other Github Issues & PRs;
  • chat with others in the Gitter Chatroom (usually for quick help: How do I do X);
  • answer Backpack questions on Stackoverflow; you get points, people get help; you can subscribe to the backpack-for-laravel tag by adding a new filter; that will send you emails when new questions come up with our tag;

Again. Thank you for the PR. You are a wonderful person. Keep 'em coming :-) Cheers!
-- Justin Case The Backpack Robot
P.S. Help in the Backpack community is rewarded with free Backpack commercial licenses. It's the least we can do. If you feel you've helped the community with PRs, help & other stuff, please shoot Tabacitu an email and ask him if you qualify for free licenses. You scratch my back, I scratch your back. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants