add support for spatie v7 and v8 and backpack 4.2 #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY
BEFORE - What was wrong? What was happening before this PR?
Could not install Backpack on Laravel 9 in the demo. Because this package used
spatie/laravel-backupv6, and it needed v8.AFTER - What is happening after this PR?
Should be able to install.
HOW
How did you achieve that, in technical terms?
Added them in
composer.json. Turns out they introduced no breaking changes in v7 and v8. Which is weird. That's not like them.Is it a breaking change or non-breaking change?
Should be non-breaking.
How can we test the before & after?
Try to
composer require backpack/backupmanager:"dev-bump-dependencies as 3.9.99"in a Laravel 9 install (might want to uselaravel/framework:"9.x-dev as 8.9.99".