[4.2][Bug] Error in text column in Permissions

[tabacitu]

Bug report

What I did

Opened Permissions CRUD in 4.2

What I expected to happen

Work

What happened

Not work 😅 Are you getting the same thing @promatik ?

What I've already tried to fix it

Nothing yet - currently deep into fixing other stuff.

Backpack, Laravel, PHP, DB version

4.2

[tabacitu]

Ok so here's a weird one. If you dd() before (or after) that particular line... it's a string. It's definitely a string.

But it turns out the problem... is a DB entry. Backpack cannot echo out a table cell that says logs because... somehow Laravel tries to turn it into a Logger object 😱 If you rename that db entry to logsss it'll work just fine.

This is... WOW...

@promatik I'll let you take a closer look at this too. Right now I was deep into something else, and it doesn't seem like this is a quick one, as I thought.

[promatik]

Hi @tabacitu!
I'm so glad this happened! this would be a HUGE error source, and it would be super hard for us to find what was happening, and we would certainly get negative feedback on this.

Fix is here #4005.

Basically;

is_callable('logs') // true

Because;

$value = 'logs';
$value() // the same as;
logs() // returns an instance of \Illuminate\Log\LogManager

All our columns have that new feature, to verify if value is a callable.

if(is_callable($column['value'])) {
    $column['value'] = $column['value']($entry);
}

it should become;

if($column['value'] instanceof \Closure) {
    $column['value'] = $column['value']($entry);
}

[pxpm]

@promatik is better to check if it's a closure or check if it is a function and not string?

I ask because in other places to avoid this error we check: is_callable($var) && !is_string($var).

Not sure if your solution covers it 100%, if it does, is indeed simpler, just want to make sure.

Best,
Pedro

[promatik]

@pxpm good point, I can't see a way for this not to work, an inline function is always an instance of \Closure, we can only send instances of \Closures right?