Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced is_callable with instanceof \Closure #4005

Merged
merged 1 commit into from
Dec 13, 2021
Merged

Conversation

promatik
Copy link
Contributor

Fix for #3984.

Basically;

is_callable('logs') // true

Because;

$value = 'logs';
$value() // the same as;
logs() // returns an instance of \Illuminate\Log\LogManager

@promatik promatik requested a review from tabacitu December 11, 2021 02:25
@tabacitu tabacitu merged commit 9d76778 into 4.2 Dec 13, 2021
@tabacitu tabacitu deleted the fix-is-callable branch December 13, 2021 05:38
@tabacitu tabacitu mentioned this pull request Dec 13, 2021
@tabacitu tabacitu mentioned this pull request Feb 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants