Fix checklist with reselection from old values #4057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Tested, was happening, now it's not. In the process, discovered ANOTHER bug in Added bug about it here - #4071 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY
BEFORE - What was wrong? What was happening before this PR?
#4056 - i just wrote it the :|
AFTER - What is happening after this PR?
checkboxes get reselected.
HOW
How did you achieve that, in technical terms?
the JS was only registering the change event for the checkboxes and it was the only place where the checking process would run (after a change).
I refactored the JS a bit so we could still run the code on change, but also on field initialization we check if any of the checkboxes are checked, it they are we trigger we manually trigger the "auto-checking" for them.
Is it a breaking change or non-breaking change?
Non breaking, probably it could go into 4.1 too ?
How can we test the before & after?
Before: Go to user create in demo, select superadmin and notice the permissions get automatically selected. If you don't fill any more fields you will get a validation error, and will notice that the role was still selected but all permissions are gone.
In this PR, the permissions are re-selected.