Add Conditionable trait to support ->when() and ->unless() #5029
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY
BEFORE - What was wrong? What was happening before this PR?
Nothing
AFTER - What is happening after this PR?
The Conditionable trait from laravel 8 is added. (Backpack minimum laravel 8 version is higher than when this is added into laravel so it is very safe)
https://www.amitmerchant.com/conditionally-executing-callbacks-conditionable-trait-laravel-8x/
I think this will greatly improve the fluent flexibility and reduce if () clauses as you can chain methods on a conditional basis in a fluent way.
HOW
How did you achieve that, in technical terms?
Add the Conditionable trait
Is it a breaking change?
No
How can we test the before & after?
Try chaining ->when() or ->unless() method and inside it call other fluent methods conditionally
Feel free to edit this PR and add the Conditionable trait to other classes too (filters, columns.etc), I can add it too if you all want but tell me which classes
I think this is a small change that is a big improvement to developer DX