add css hooks to buttons, wrap button text in a span #5343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tabacitu
reviewed
Oct 12, 2023
tabacitu
reviewed
Oct 12, 2023
pxpm
force-pushed
the
add-span-to-buttons
branch
from
b5e4e40 to
27bfb1a
Compare
pxpm
changed the title
This was referenced Aug 14, 2024
tabacitu
requested changes
Aug 15, 2024
tabacitu
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reported in #5010
we could make developers life easier when they want to hide the button text and display only an icon by wrapping the button text in a span as suggested by @tabacitu
I've decided to create a class for each button type, eg:
create-button-text-span,update-button-text-span. That way developers have the ability to hide only specific button texts, or hide all of them with*-button-text-spanselector.