Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] This module seems to be causing a sizeable memory leak in my world. #292

Closed
Cthoodles opened this issue Nov 22, 2024 · 2 comments
Closed
Labels
bug Something isn't working

Comments

@Cthoodles
Copy link

Describe the bug
This module seems to be responsible for a memory leak that slows the performance of my foundry world. It's noticable fairly immediately, and gets worse over time. I used chrome's dev tools to check for the source of the leak and this module seems to be it--I also tested with only this module installed and no others.
image

Steps to reproduce

  1. Go to a Foundry world with this module installed
  2. Click on several different tokens, with the Token Action HUD popping up each time
  3. Memory leak seemingly accumulates with each token clicked on.

Versions:

  • Token Action HUD Core: 2.0.8
  • Token Action HUD Pathfinder 2e: 2.0.3
  • System: Pathfinder 2e 6.7.0
  • Foundry VTT: 12.331
  • Browser: Google Chrome 131.0.6778.86

Additional context
I host my world through Forge if that might make any difference somehow.
Tested with all my modules installed, with just Token Action HUD & Token Action HUD Pathfinder 2e installed, and with no modules installed. This module or the PF2e system module definitely seems to be the culprit.

@Cthoodles Cthoodles added the bug Something isn't working label Nov 22, 2024
@Larkinabout
Copy link
Owner

I've made some tweaks that I'll include in the next release, which I think has removed the detached objects related to the HUD.

I've noticed that the memory still creeps up even with these tweaks, but also with Token Action HUD disabled, so it looks like it's not exclusively Token Action HUD.

Larkinabout added a commit that referenced this issue Nov 27, 2024
- #292: Clear some objects that may hold onto memory.
@Larkinabout
Copy link
Owner

Found this on the pf2e system GitHub, so it looks like someone coincidentally also identified the same issues with memory leaks in the system. Looks like it should be resolved for next release: foundryvtt/pf2e#17483

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants