-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade lodash packages #16
Conversation
danparnella
commented
Mar 14, 2024
•
edited
Loading
edited
- Resolves lodash dependency issue on projects that use this package
- Switches from per-method packages to the latest whole version of the lodash package: 4.17.21
- Per method packages didn't appear to be updated as recently and I found this resource that recommended against that anyway: https://medium.com/swlh/dont-use-lodash-per-method-packages-507409a87959
@chawes13 You were suggested, but let me know if someone else should be the reviewer here. |
@danparnella It's me. Is this for a client project? In other words, what's the timeline you're looking for here? |
Can you confirm what the delta is in the bundle size? |
I was hoping to include it for this release (ending Monday) on ATBS (where I'm upgrading dependency packages) to resolve this dependabot alert.
Any pointers on finding that? I saw this tool, but it feels like overkill: https://github.com/webpack-contrib/webpack-bundle-analyzer. |
That's what we use on the client template! https://github.com/LaunchPadLab/client-template/blob/13bf74803d0ba3871d9263fddf533f29855bd1da/package.json#L12 I don't think we need to add it to the package though, so you could just use npx to run it |
@chawes13 I'm not entirely sure I did it correctly. I was seeing this error:
But I did get it to spit out a json file with a "statSize" for each branch:
I would think that's expected, but wouldn't cause an overall increase in most of our situations since we import |
Ah I see. Can you confirm that by linking this locally with ATBS or a fresh client-template project? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the article link!