Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade lodash packages #16

Merged
merged 4 commits into from
Mar 15, 2024
Merged

Upgrade lodash packages #16

merged 4 commits into from
Mar 15, 2024

Conversation

danparnella
Copy link
Contributor

@danparnella danparnella commented Mar 14, 2024

@danparnella danparnella marked this pull request as draft March 14, 2024 19:38
@danparnella danparnella marked this pull request as ready for review March 14, 2024 19:58
@danparnella danparnella requested a review from chawes13 March 14, 2024 19:59
@danparnella
Copy link
Contributor Author

@chawes13 You were suggested, but let me know if someone else should be the reviewer here.

@chawes13
Copy link
Contributor

@danparnella It's me. Is this for a client project? In other words, what's the timeline you're looking for here?

@chawes13
Copy link
Contributor

Can you confirm what the delta is in the bundle size?

@danparnella
Copy link
Contributor Author

@danparnella It's me. Is this for a client project? In other words, what's the timeline you're looking for here?

I was hoping to include it for this release (ending Monday) on ATBS (where I'm upgrading dependency packages) to resolve this dependabot alert.

Can you confirm what the delta is in the bundle size?

Any pointers on finding that? I saw this tool, but it feels like overkill: https://github.com/webpack-contrib/webpack-bundle-analyzer.

@chawes13
Copy link
Contributor

That's what we use on the client template! https://github.com/LaunchPadLab/client-template/blob/13bf74803d0ba3871d9263fddf533f29855bd1da/package.json#L12

I don't think we need to add it to the package though, so you could just use npx to run it

@danparnella
Copy link
Contributor Author

@chawes13 I'm not entirely sure I did it correctly. I was seeing this error:

Error parsing bundle asset "/workspaces/dot-index-webpack-plugin/main.js": no such file

No bundles were parsed. Analyzer will show only original module sizes from stats file.

But I did get it to spit out a json file with a "statSize" for each branch:

  • main: "statSize": 194021
  • branch: "statSize": 692419

I would think that's expected, but wouldn't cause an overall increase in most of our situations since we import lodash already in the client templates.

@chawes13
Copy link
Contributor

Ah I see. Can you confirm that by linking this locally with ATBS or a fresh client-template project?

Copy link
Contributor

@chawes13 chawes13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the article link!

@chawes13 chawes13 merged commit ac1d816 into main Mar 15, 2024
1 check passed
@chawes13 chawes13 deleted the chore/upgrade-lodash branch March 15, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants