Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue - Search bar is not clickable and off-margin #2495

Closed
imudayveer opened this issue Dec 25, 2024 · 5 comments
Closed

Issue - Search bar is not clickable and off-margin #2495

imudayveer opened this issue Dec 25, 2024 · 5 comments
Assignees
Labels
bug Something isn't working. discussion

Comments

@imudayveer
Copy link

About this discussion

Below is the picture of how Lawicons app looks like. As said in subject, the search bar is not clickable.

OS Version - Android 15

Application Version
version 2.12.0
app.lawnchair.lawnicons.play

Screenshot_20241224-214241

@SuperDragonXD
Copy link
Contributor

SuperDragonXD commented Dec 25, 2024

Interesting. To check, does this happen when you launch the app or do a specific action? The search bar is not supposed to be visible unless you click the search button at the bottom bar.

To note, this is the intended behavior:

Screen_Recording_20241225_140000.mp4

Can you also reproduce this at the latest nightly? Also, what is your device name and screen size/density?

@imudayveer
Copy link
Author

Same behavior on Nightly version.
version 2.12.0 (Dev #6303)
app.lawnchair.lawnicons

The issue happens on startup. Attached is the video. (Ignore the pixelation, compressed video)

screen-20241225-002006.mp4

@imudayveer
Copy link
Author

My device is Pixel 9 Pro. My screen width is 426 dp according to Developer Options.

@SuperDragonXD SuperDragonXD added the bug Something isn't working. label Dec 25, 2024
@SuperDragonXD SuperDragonXD self-assigned this Dec 25, 2024
@SuperDragonXD
Copy link
Contributor

I see. Looks like the larger status bar height showed the "hidden" search bar (moving the bar 100px to the top isn't enough ig :D). I will refactor the search bar soon to be located near the bottom, so this issue should be fixed once I've pushed those changes.

@imudayveer
Copy link
Author

Thanks!

RaduBratan added a commit to RaduBratan/Lawnicons that referenced this issue Jan 1, 2025
commit be70b37
Author: 92 <[email protected]>
Date:   Wed Jan 1 17:43:05 2025 +0900

    +1 icon (LawnchairLauncher#2488)

    * +1 icon

    `5ber.eSIM` `com.ifreegroup.moesim`

    |![old](https://github.com/user-attachments/assets/3d6322a4-b579-4670-89d0-6615b912c3d8)|![new](https://raw.githubusercontent.com/Twive/lawnicons/refs/heads/develop/svgs/_5ber_esim.svg)|
    |---|---|

    * Update _5ber_esim.svg

    * Add files via upload

commit b20916c
Author: Gleb <[email protected]>
Date:   Tue Dec 31 11:08:21 2024 +0300

    Minor icon improvements (LawnchairLauncher#2502)

    * Minor icon improvements

    * Update quizduel.svg

commit 8e6fecc
Author: 92 <[email protected]>
Date:   Tue Dec 31 16:49:47 2024 +0900

    Update README.md (LawnchairLauncher#2487)

commit 3accd38
Author: Gleb <[email protected]>
Date:   Mon Dec 30 14:03:37 2024 +0300

    Minor config.yml fix (LawnchairLauncher#2501)

commit 879bad0
Author: Gleb <[email protected]>
Date:   Mon Dec 30 13:56:53 2024 +0300

    Suspension of icon requests (LawnchairLauncher#2500)

    Added a hint to the issue template.

commit 6289116
Author: SuperDragonXD <[email protected]>
Date:   Fri Dec 27 13:35:12 2024 +0800

    Search improvements

    - Improve animations when opening search bar
    - Temporary fix to search bar showing on tall devices; fixes LawnchairLauncher#2495
    - Open first item when pressing search button in IME

commit ddc8641
Author: SuperDragonXD <[email protected]>
Date:   Fri Dec 27 11:57:56 2024 +0800

    Cleanup preferences handling

commit 6b371f9
Author: SuperDragonXD <[email protected]>
Date:   Wed Dec 25 21:47:58 2024 +0800

    feat: Allow enabling/disabling icon requests

    This can be done via the flag at the website repo, or via the local prefs override at the debug menu.

    TODO: Update link once new form is placed.

commit fcc7be4
Author: Gleb <[email protected]>
Date:   Sat Dec 21 19:35:34 2024 +0300

    Removed the deleted form (LawnchairLauncher#2494)

    * Removed the deleted form

    * Update icon_rebrand.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working. discussion
Projects
None yet
Development

No branches or pull requests

2 participants