-
Notifications
You must be signed in to change notification settings - Fork 466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
+3 icons #2336
+3 icons #2336
Conversation
Thanks for your contribution! While waiting for a review from our team, you can do a self-review to ensure that your icons are suitable for Lawnicons. We try to do the review within 7 days. Canvas and sizes
Color, stroke width and rounding
Naming
Quality
|
In the screenshot, you can see that only the first icon has the correct size. Try to make icons without fills and masks. This way they will fully comply with the Lawnicons guidelines. They will be easy to check and change if ever needed.
For example, you can create a 12×12px square with 12px stroke width instead of the square with a fill. |
As an aside, especially I feel that the shapes in the HungerBox icon look visually different in size due to the negative space inside being different for different shapes. Let me know if I should change them so that the whitespace inside each is uniform. |
You can balance the top part of the icon better if you want. I would increase the height of the icon to 160px ± 0.05px. It is also worth moving the bottom part slightly to the left so that it is in the center. |
Interesting since I did not explicitly use masks. Saw the svg code and somehow Figma is making closed path's strokes which are aligned as inside instead of center as a mask. (Sorry not a frequent figma user, if this was a common knowledge) I re-made 3D calculator icon. Check if the jagged-ness issue is now resolved or not, since no masks in the svg code this time. |
Everything is smooth. |
Great, thanks! |
Thanks. I see that you made some tweaks before merging. Would love to hear feedback about what was off, if you're free ofc. |
entrust_identity.svg – the icon size was smaller than needed. |
* Added Icons for Entrust Identity, Geogebra 3D Calculator and HungerBox Cafe * Enlarged Entrust Identity icon * Modified HungerBox Cafe icon * Remade 3d calculator icon * Re-made entrust identity icon * Re-made hungerbox icon * Icon size fix – entrust_identity.svg * Icon size + visual center fix – geogebra_3d_calculator.svg * Less density + center alignment — hungerbox_cafe.svg --------- Co-authored-by: Gleb <[email protected]>
Description
Added icons for 3 apps. Contributing icons for first time, let me know if any changes are required.
In particular, the following choices were made by me:
Icons addition information
Added
GeoGebra 3D Calculator (org.geogebra.android.g3d/org.geogebra.android.privatelibrary.splashscreen.SplashScreenActivity)
HungerBox Cafe (com.hungerbox.customer.common/com.hungerbox.customer.prelogin.activity.MainActivity)
Entrust Identity (com.entrust.identityGuard.mobile/com.entrust.identityGuard.mobile.MainActivity)
Contributor's checklist