Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

+1 icon #2470

Merged
merged 1 commit into from
Dec 16, 2024
Merged

+1 icon #2470

merged 1 commit into from
Dec 16, 2024

Conversation

I21b
Copy link
Contributor

@I21b I21b commented Nov 30, 2024

P:h Diver com.NextFloor.phdiver
ph_diver

`P:h Diver` `com.NextFloor.phdiver`
![ph_diver](svgs/ph_diver.svg)
@github-actions github-actions bot added the icons This PR modifies Lawnicons by adding, removing, or mapping an icon to a SVG. label Nov 30, 2024
Copy link
Contributor

Thanks for your contribution!

We hope that you followed the Lawnicons guidelines and made sure that Lawnicons is built correctly.

Tip

While waiting for a brief and strict review from our team, you can do a self-review to ensure that your icons are suitable for Lawnicons. Additionally, you can find and install the debug build of your PR.

Lawnicons guidelines

Quality

  1. Ensure that icons are easily recognizable.
  2. Align icons to the visual center as much as possible within the guidelines. The visual center is where your icon looks and feels centered.
  3. Avoid noticable black spots by reducing the stroke width or simplifying the icons.
  4. Avoid close distances between strokes. The icons on the phone screen will be smaller, so the small distances between the strokes will stick together.
  5. Avoid drastic changes in stroke widths. When the strokes next to each other differ in width by 4px or more, the icon will look sloppy.

Canvas and sizes

  1. Canvas: 192×192px.
  2. Non-square icons: the long side of the icons should be 160px.
  3. Square icons: 154×154px.

Color, stroke width and rounding

  1. Color: non-transparent black #000.
  2. No fill. Base stroke width: 12px. 14px, 10px, 8px — depending on the shape of the icons. 6px — for fine details.
  3. Rounded ends and joins. 90° corners are rounded by 6-32px.

Naming

  1. Names should match the official app name and contain no additional text.
  2. If the first 3 characters of the app name contain letters not from the English alphabet, then add a localized (or transliterated) name via ~~. Example: 京东 ~~ JD.
  3. The names of the drawables should repeat the names of the apps if nothing prevents it.

@I21b
Copy link
Contributor Author

I21b commented Nov 30, 2024

original icon here

jpg

@I21b

This comment has been minimized.

@I21b I21b marked this pull request as draft December 1, 2024 04:04
@I21b
Copy link
Contributor Author

I21b commented Dec 1, 2024

ph_diverori
@x9136 either or neither

@I21b I21b marked this pull request as ready for review December 1, 2024 18:00
@x9136
Copy link
Collaborator

x9136 commented Dec 16, 2024

Your option is good enough to accept. Although I would look for even more opportunities to increase the space between the lines, which are now very close.

@x9136 x9136 merged commit a64b018 into LawnchairLauncher:develop Dec 16, 2024
7 checks passed
@I21b
Copy link
Contributor Author

I21b commented Dec 16, 2024

Your option is good enough to accept. Although I would look for even more opportunities to increase the space between the lines, which are now very close.

It's a little hard to make adjustments, but this just works, so leaving it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
icons This PR modifies Lawnicons by adding, removing, or mapping an icon to a SVG.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants