Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-blocking read option on socket #278

Merged
merged 3 commits into from
Dec 24, 2024

Conversation

cspencer404
Copy link
Contributor

@cspencer404 cspencer404 commented Oct 10, 2023

Created WebSocket.sock_timeout property to be able to use sock.settimeout(self.sock_timeout) for non-blocking reads when a timeout value is provided. When the default value of None is used, the blocking behavior is unchanged.

@auvipy auvipy self-requested a review November 10, 2023 06:31
Copy link
Collaborator

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please rebase it?

ws4py/websocket.py Outdated Show resolved Hide resolved
Signed-off-by: Asif Saif Uddin <[email protected]>
test/test_websocket.py Show resolved Hide resolved
Signed-off-by: Asif Saif Uddin <[email protected]>
@auvipy auvipy merged commit 3c3cc34 into Lawouach:master Dec 24, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants