wallet: add support for initiating from seed file #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mplatt8
changed the title
torkelrogstad
requested changes
Feb 14, 2025
lib/wallet/mnemonic.rs
Outdated
Comment on lines
34
to
39
| if words.len() != 12 { | ||
| return Err(miette!( | ||
| "mnemonic must be exactly 12 words, got {}", | ||
| words.len() | ||
| )); | ||
| } |
There was a problem hiding this comment.
Is this a hard requirement from our side? Validity of the mnemonic is verified on line 41, and valid mnemonics can be of various lengths
torkelrogstad
force-pushed
the
mnemonic-arg
branch
from
0e22771 to
1bc01ce
Compare
torkelrogstad
changed the title
torkelrogstad
force-pushed
the
mnemonic-arg
branch
from
1bc01ce to
256a91a
Compare
torkelrogstad
force-pushed
the
mnemonic-arg
branch
from
256a91a to
3318162
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.