Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🪚 Schemas for OApp config #141

Merged
merged 10 commits into from
Jan 3, 2024
Merged

🪚 Schemas for OApp config #141

merged 10 commits into from
Jan 3, 2024

Conversation

janjakubnanista
Copy link
Contributor

@janjakubnanista janjakubnanista commented Jan 2, 2024 •
edited
Loading

In this PR

  • Add some atomic schemas (UIntSchema)
  • Add schemas for some of the types that did not have schemas yet
  • Fix types for OAppOmniGraphHardhat
  • Fix broken imports (some imports were using filesystem paths instead of package paths)
  • Name some interfaces (instead of using nested anonymous ones) for OApp configs

@TRileySchwarz TRileySchwarz merged commit 39f08f7 into main Jan 3, 2024
1 check passed
@TRileySchwarz TRileySchwarz deleted the oapp-schema branch January 3, 2024 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TRileySchwarz TRileySchwarz TRileySchwarz approved these changes

@sirarthurmoney sirarthurmoney Awaiting requested review from sirarthurmoney

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@janjakubnanista @TRileySchwarz