OFT v2 Refactoring to support uint256 amount #53
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The scope of this PR:
type(uint64).max
limit foramount
fromOFTV2Core
,ProxyOFTV2
andProxyOFTWithFee
OFTV2Aptos
,ProxyOFTV2Aptos
,ProxyOFTWithFeeAptos
that allow no more than 6 shared decimals and havetype(uint64).max
limit foramount
abi.encodePacked
withabi.encode
inOFTV2Core
and derived contractsUsing
abi.encodePacked
makes encoding inconsistent with previous versions and decoding ugly. Additionally,abi.encodePacked
will be removed in a future version of Solidity (see Remove abi.encodePacked ethereum/solidity#11593)NOTE: there isn't a good way to extract all Aptos overrides in one contract (diamond inheritance problem), thus the same code is duplicated in
OFTV2Aptos
,ProxyOFTV2Aptos
, andProxyOFTWithFeeAptos
contracts. The same issue is present inProxyOFTV2
andProxyOFTWithFee