fix: Disable SERVICE_MANAGER_ADDR & ETH_RPC as mandatory
#205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethenotethan
changed the title
SERVICE_MANAGER_ADDR & ETH_RPC as mandatory
samlaf
reviewed
Dec 3, 2024
samlaf
reviewed
Dec 3, 2024
|
How/where does the proxy crash? If we are using the latest version of eigenda_client (which I think we are?), those fields are actually mandatory, even if we don't do cert checking. |
… client override when memstore enabled
samlaf
reviewed
Dec 3, 2024
…dress PR comment and add unit test
samlaf
reviewed
Dec 3, 2024
ethenotethan
deleted the
epociask--fix-disable-cert-verif-params-mandatory
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed
Fixes a config processing bug where cert verification can be disabled but the application will crash since the service manager and eth rpc params are still required even-though they shouldn't be.
Created #206 to identify that there are better solutions.