v2 Retrieval Client #953
Merged
v2 Retrieval Client #953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cody-littley
approved these changes
Dec 5, 2024
| } | ||
|
|
||
| // NewRetrievalClientV2 creates a new retrieval client. | ||
| func NewRetrievalClientV2( |
There was a problem hiding this comment.
This fetches the data directly from the DA nodes. Should we first attempt to fetch the data from the relays? Or is this the job of another layer of the system?
There was a problem hiding this comment.
This fetches the data directly from the DA nodes. Should we first attempt to fetch the data from the relays? Or is this the job of another layer of the system?
Yes, that is done using the relay client. This client is meant to be the client used to retrieve from the DA nodes.
Whatever is integrating retrieval should choose to integrate using one or both of these clients.
There was a problem hiding this comment.
Clarified this in the comment
ian-shim
force-pushed
the
retrieval-client-v2
branch
from
8ef8338 to
7ff0ff8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Implements a client that queries chunks from DA nodes and reconstructs the blob
Checks