Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix BLS signature #174

Merged
merged 6 commits into from
Dec 11, 2024
Merged

Fix BLS signature #174

merged 6 commits into from
Dec 11, 2024

Conversation

pablodeymo
Copy link
Collaborator

@pablodeymo pablodeymo commented Dec 4, 2024 •
edited
Loading

This PR changes the signature of sign_message to:

pub fn sign_message(&self, message: &[u8; 32]) -> Signature

and fixes the implementation of map_to_curve. There was a minor bug in the parsing of the input (endianness mismatch).

@shrimalmadhur shrimalmadhur mentioned this pull request Dec 4, 2024
Closed
@pablodeymo pablodeymo changed the title [WIP] Fix signature Fix BLS signature Dec 6, 2024
@pablodeymo pablodeymo marked this pull request as ready for review December 6, 2024 20:11
@pablodeymo pablodeymo merged commit d716fc0 into main Dec 11, 2024
3 checks passed
@pablodeymo pablodeymo deleted the fix_signature branch December 11, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shrimalmadhur shrimalmadhur shrimalmadhur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pablodeymo @shrimalmadhur