Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: remove delegation manager from ELChainWriter #214

Merged
merged 4 commits into from
Jan 15, 2025
Merged

Conversation

supernovahs
Copy link
Collaborator

@supernovahs supernovahs commented Jan 10, 2025

This PR removes the delegation manager field from ELChainWriter. This field was previously added to the ELChainReader, so the ELChainWriter now fetches it from its reader.

Copy link
Contributor

@MegaRedHand MegaRedHand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although we should keep the ubuntu version as latest

@supernovahs supernovahs merged commit 5ce424c into main Jan 15, 2025
2 of 3 checks passed
@supernovahs supernovahs deleted the nova/el branch January 15, 2025 14:23
MegaRedHand added a commit that referenced this pull request Jan 15, 2025
@MegaRedHand MegaRedHand changed the title remove duplicate delegation manager in ELWriter feat!: remove delegation manager from ELChainWriter Jan 17, 2025
@MegaRedHand MegaRedHand added the changelog-breaking [changelog] PR changes existing functionality label Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-breaking [changelog] PR changes existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants