Web3 signer functionality #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ricomateo this contains part of the same code as the |
|
@dralves I could merge the other branch but it needs a workflow approval |
ricomateo
changed the title
ricomateo
changed the title
dralves
reviewed
Jul 30, 2024
crates/signer/src/signer.rs
Outdated
| assert_eq!(signer.address(), recovered_address); | ||
| } | ||
|
|
||
| // This test will fail if anvil is not installed (Foundry contains anvil) |
There was a problem hiding this comment.
could you add this and the docker prereqs to run tests to the docs?
There was a problem hiding this comment.
do you mean the rust docs comments? or should we add a README.md with the signer docs?
There was a problem hiding this comment.
I meant to add this to the parent/root readme, since these tests run with the rest of the tests and these pre-reqs are required for the tests to pass
dralves
reviewed
Jul 30, 2024
dralves
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR branches from lambdaclass:signer branch
This PR adds web3 signer functionality. At the moment we have implemented: