Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

logging integration #62

Merged
merged 14 commits into from
Aug 8, 2024
Merged

logging integration #62

merged 14 commits into from
Aug 8, 2024

Conversation

supernovahs
Copy link
Collaborator

No description provided.

@supernovahs
Copy link
Collaborator Author

leaving logging for bls agg for now . since it will be re implemented a lot anywayy
will do operators info memory after #59 gets merged

@supernovahs
Copy link
Collaborator Author

Some logging pending for metrics

@supernovahs
Copy link
Collaborator Author

tags criteria for logging
crate-name.file-name.function-name

@supernovahs supernovahs marked this pull request as ready for review August 1, 2024 19:12
@supernovahs supernovahs mentioned this pull request Aug 2, 2024
Merged
7 tasks
dralves
dralves reviewed Aug 6, 2024
View reviewed changes
crates/chainio/clients/elcontracts/Cargo.toml Show resolved Hide resolved
crates/chainio/clients/elcontracts/Cargo.toml Outdated Show resolved Hide resolved
crates/logging/Cargo.toml Outdated Show resolved Hide resolved
crates/logging/src/tracing_logger.rs Outdated Show resolved Hide resolved
crates/metrics/Cargo.toml Show resolved Hide resolved
crates/services/bls_aggregation/Cargo.toml Outdated Show resolved Hide resolved
crates/services/bls_aggregation/src/bls_agg.rs Outdated Show resolved Hide resolved
crates/services/bls_aggregation/src/bls_agg.rs Outdated Show resolved Hide resolved
examples/avsregistry-read/Cargo.toml Outdated Show resolved Hide resolved
examples/info-operator-service/Cargo.toml Outdated Show resolved Hide resolved
@supernovahs supernovahs requested a review from dralves August 6, 2024 14:11
dralves
dralves approved these changes Aug 6, 2024
View reviewed changes
Copy link
Collaborator

@dralves dralves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only one nit missing, approving assuming it will be addressed

@supernovahs supernovahs mentioned this pull request Aug 7, 2024
Merged
@supernovahs supernovahs merged commit 6457627 into main Aug 8, 2024
1 check passed
@supernovahs supernovahs deleted the supernovahs/logging_integration branch August 14, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dralves dralves dralves approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@supernovahs @dralves