Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

egnaddrs cli functionality #64

Merged
merged 17 commits into from
Aug 6, 2024

Conversation

ricomateo
Copy link
Contributor

@ricomateo ricomateo commented Aug 1, 2024

Description
This PR adds the following changes

  • egnaddrs CLI functionality used to output addresses for all relevant Eigenlayer and AVS contracts within the network.

@ricomateo ricomateo marked this pull request as ready for review August 2, 2024 15:43
Cargo.toml Show resolved Hide resolved
about = "Used to help debug and test deployments and contract setups.",
long_about = "This utility facilitates the debugging and testing of Eigenlayer and AVS contract deployments by retrieving and displaying a comprehensive list of contract addresses. Starting from an initial contract address provided, it recursively identifies and prints addresses for all relevant Eigenlayer and AVS contracts within the network. This includes service managers, registry coordinators, and various registries, thus providing a view of the deployment's structure within the network."
)]
pub struct Args {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would it make sense to separate this into clap subcommands? (start with one for eigedaddrs and then add one for eigenkey and later for other stuff?)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean having all the clap stuff (for both egnaddrs and egnkey) in a single args.rs file?
We were thinking of having egnaddrs and egnkey as separated crates, each with its own args.rs.
Which way should we do it?

Copy link
Collaborator

@dralves dralves Aug 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, don't think there's an advantage in having two command line binaries, we might even have to add more subcommands in the future

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

crates/eigen-cli/src/eigen_address.rs Outdated Show resolved Hide resolved
@supernovahs supernovahs merged commit 5c26e69 into Layr-Labs:main Aug 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants