Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc port from go sdk and crate readme #65

Merged
merged 15 commits into from
Aug 6, 2024
Merged

Conversation

supernovahs
Copy link
Collaborator

No description provided.

@supernovahs supernovahs marked this pull request as ready for review August 5, 2024 15:05
@supernovahs supernovahs requested a review from dralves August 5, 2024 15:06
@supernovahs
Copy link
Collaborator Author

Let me know what else should we port from the go sdk

crates/services/avsregistry/README.md Show resolved Hide resolved
crates/services/bls_aggregation/README.md Show resolved Hide resolved

## AvsRegistry Read
```
cargo run -p examples-avsregistry-read
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add some test as to what these do?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a push , the command was wrong . wdym by test?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same, text

examples/README.md Show resolved Hide resolved
testing/testing-utils/README.md Show resolved Hide resolved
@supernovahs supernovahs requested a review from dralves August 6, 2024 14:26
Copy link
Collaborator

@dralves dralves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only a couple of nits missing, approving assuming those will be fixed

@supernovahs supernovahs merged commit 620195f into main Aug 6, 2024
1 check failed
@supernovahs supernovahs deleted the supernovahs/docs_port branch August 14, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants