-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
egnkey cli functionality #71
Conversation
Co-authored-by: Mateo Rico <[email protected]>
this needs some changes after #69 is merged |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
naming for ecdsa keystore
crates/eigen-cli/src/lib.rs
Outdated
use convert::store; | ||
use eigen_crypto_bls::error::BlsError; | ||
use generate::KeyGenerator; | ||
use operator_id::derive_operator_id; | ||
use thiserror::Error; | ||
pub mod args; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
separate the module declarations form imports
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some small nits
also @dralves do we want the test naming convention to be test_name or just name? because the tests above don't use test as prefix , while we are doing that in other crates . |
good call. let's keep it consistent |
@supernovahs @dralves I just fixed the test naming. Should we create a new PR fixing this issue in the other crates? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
^
yup would be better to make that for another PR . I'll do that no worries |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
^
Blocked by #69 |
@ricomateo this is now unblocked, has some conflicts from bls crate sorry |
Description
This PR adds the following CLI commands
egnaddrs
egnkey
generate
convert
derive-operator-id