Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bls Keystore and Mnemonic #72

Merged
merged 54 commits into from
Aug 16, 2024
Merged

Bls Keystore and Mnemonic #72

merged 54 commits into from
Aug 16, 2024

Conversation

supernovahs
Copy link
Collaborator

@supernovahs supernovahs commented Aug 9, 2024 •
edited
Loading

This PR integrates https://github.com/Layr-Labs/rust-bls-bn254

  • [Keystore]

  • [Mnemonic]

ricomateo and others added 30 commits July 30, 2024 17:59
@ricomateo
add skeleton
142141c
@TomasArrachea
add commands info and load provider
03b9dad
@ricomateo
add contract addresses
28f684e
@TomasArrachea
remove unused crates
29fe3bb
@TomasArrachea
add testing against sdk-go output
80e15df
@ricomateo
add error handling and reorganize eigen-cli crate
2a81e79
@ricomateo
add EigenAddressCliError type and reorganize egnaddrs crate (remove e…
7d1fadd 
…gnaddr bin)
@pablodeymo
add documentation to functions and fixing spaces
f70121d
@TomasArrachea
add param checking with clap
3d672f5
@TomasArrachea
update tests expected result and rename addresses structs
6cca229
@TomasArrachea
remove todo
6b65333
@ricomateo
fix merge conflicts
1767313
@ricomateo
add doc attribute in lib.rs
ad2f495
@TomasArrachea
add egnkey initial implementation
fb718d4
@TomasArrachea @ricomateo
add ecdsa key generation
ba64fe7 
Co-authored-by: Mateo Rico <[email protected]>
@TomasArrachea
add ecdsa test
3746bf8
@TomasArrachea
add generate bls keys implementation
57d5104
@ricomateo
add convert command functionality
47a34c4
@ricomateo
add documentation to KeyGenerator functions
a3513e8
@TomasArrachea
add error handling and move password creation
aae6b19
@TomasArrachea
Merge branch 'main' into cmd-egnkey
7f46f61
@TomasArrachea
fix merge egnaddrs
5bb7ab3
@ricomateo
join egnaddr and egnkey into a single crate
68e16d8
@ricomateo
change error handling in execute_command function
bdf98e3
@ricomateo
change args commands so that it matches the eigensdk-go spec
6cf80a6
@ricomateo
add documentation
9ba3815
@ricomateo
add derive-operator-id command implementation
ed13aeb
@ricomateo
add test for derive-operator-id command
f371a7a
@ricomateo
add documentation and error handling
13fe3f3
@ricomateo
fix cargo.toml
5a540fb
@supernovahs supernovahs added enhancement New feature or request and removed S-blocked labels Aug 13, 2024
anupsv
anupsv approved these changes Aug 13, 2024
View reviewed changes
Copy link

@anupsv anupsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few comments, but overall ok.

supernovahs
supernovahs commented Aug 14, 2024
View reviewed changes
Copy link
Collaborator Author

@supernovahs supernovahs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^

@supernovahs supernovahs requested a review from dralves August 14, 2024 11:07
dralves
dralves requested changes Aug 15, 2024
View reviewed changes
crates/eigen-cli/Cargo.toml Outdated Show resolved Hide resolved
crates/eigen-cli/src/lib.rs Show resolved Hide resolved
crates/eigen-cli/src/lib.rs Outdated Show resolved Hide resolved
crates/eigen-cli/src/lib.rs Outdated Show resolved Hide resolved
crates/eigen-cli/src/bls.rs Show resolved Hide resolved
crates/eigen-cli/src/bls.rs Show resolved Hide resolved
@supernovahs supernovahs merged commit 5d9a2cc into main Aug 16, 2024
1 check passed
@supernovahs supernovahs deleted the supernovahs/bls_keystore branch August 16, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anupsv anupsv anupsv approved these changes

@dralves dralves dralves approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@supernovahs @dralves @anupsv @ricomateo @TomasArrachea @pablodeymo