Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow users to create their own wrappers #16743

Closed
wants to merge 1 commit into from
Closed

allow users to create their own wrappers #16743

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 15 additions & 15 deletions awesomplete.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,16 +5,16 @@
clip: rect(0, 0, 0, 0);
}

div.awesomplete {
.awesomplete-wrapper {
display: inline-block;
position: relative;
}

div.awesomplete > input {
.awesomplete-wrapper > input {
display: block;
}

div.awesomplete > ul {
.awesomplete-wrapper > ul {
position: absolute;
left: 0;
z-index: 1;
Expand All @@ -31,19 +31,19 @@ div.awesomplete > ul {
text-shadow: none;
}

div.awesomplete > ul[hidden],
div.awesomplete > ul:empty {
.awesomplete-wrapper > ul[hidden],
.awesomplete-wrapper > ul:empty {
display: none;
}

@supports (transform: scale(0)) {
div.awesomplete > ul {
.awesomplete-wrapper > ul {
transition: .3s cubic-bezier(.4,.2,.5,1.4);
transform-origin: 1.43em -.43em;
}

div.awesomplete > ul[hidden],
div.awesomplete > ul:empty {
.awesomplete-wrapper > ul[hidden],
.awesomplete-wrapper > ul:empty {
opacity: 0;
transform: scale(0);
display: block;
Expand All @@ -52,7 +52,7 @@ div.awesomplete > ul:empty {
}

/* Pointer */
div.awesomplete > ul:before {
.awesomplete-wrapper > ul:before {
content: "";
position: absolute;
top: -.43em;
Expand All @@ -67,31 +67,31 @@ div.awesomplete > ul:empty {
transform: rotate(45deg);
}

div.awesomplete > ul > li {
.awesomplete-wrapper > ul > li {
position: relative;
padding: .2em .5em;
cursor: pointer;
}

div.awesomplete > ul > li:hover {
.awesomplete-wrapper > ul > li:hover {
background: hsl(200, 40%, 80%);
color: black;
}

div.awesomplete > ul > li[aria-selected="true"] {
.awesomplete-wrapper > ul > li[aria-selected="true"] {
background: hsl(205, 40%, 40%);
color: white;
}

div.awesomplete mark {
.awesomplete-wrapper mark {
background: hsl(65, 100%, 50%);
}

div.awesomplete li:hover mark {
.awesomplete-wrapper li:hover mark {
background: hsl(68, 101%, 41%);
}

div.awesomplete li[aria-selected="true"] mark {
.awesomplete-wrapper li[aria-selected="true"] mark {
background: hsl(86, 102%, 21%);
color: inherit;
}
10 changes: 6 additions & 4 deletions awesomplete.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,10 +39,12 @@ var _ = function (input, o) {

// Create necessary elements

this.container = $.create("div", {
className: "awesomplete",
around: input
});
this.container = input.parentNode.className.search(/awesomplete-wrapper/) >= 0 ?
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not classList.contains("awesomplete-wrapper")?
(if the answer is "browser support", IE9 can go fu…erm use a polyfill)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, that's why. Carries no real cost, so might as well.

input.parentNode :
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for a ternary here. You can just do something like $(".awesomplete-wrapper", parent) || $.create(...)

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

help

$.create("div", {
className: "awesomplete-wrapper",
around: input
});

this.ul = $.create("ul", {
hidden: "",
Expand Down
17 changes: 9 additions & 8 deletions awesomplete.min.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 9 additions & 0 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,15 @@ <h1>Basic usage</h1>
<p>Before you try anything, you need to include <code>awesomplete.css</code> and <code>awesomplete.js</code> in your page, via the usual <code>&lt;link rel="stylesheet" href="awesomplete.css" /></code> and <code>&lt;script src="awesomplete.js" async>&lt;/script></code> tags.</p>

<p>For the autocomplete, you just need an <code>&lt;input></code> text field (might work on <code>&lt;textarea></code> and elements with <code>contentEditable</code>, but that hasn’t been tested). Add <code>class="awesomplete"</code> for it to be <strong>automatically processed</strong> (you can still specify many options via HTML attributes), otherwise you can instantiate with a few lines of JS code, which allow for more customization.</p>

<p><strong>Note:</strong> Awesomplete will wrap your input in a div with the class 'awesomplete-wrapper'. If other elements need to stay with your input, such as a label, you can simply make the wrapper yourself and Awesomplete will pick it up:

<pre class="language-markup"><code>&lt;div class="awesomplete-wrapper">
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to show an actual label here, not another div.

&lt;input class="awesomplete"
data-list="Ada, Java, JavaScript, Brainfuck, LOLCODE, Node.js, Ruby on Rails" />
&lt;label>My label&lt;/label>
&lt;div></code></pre>

<p>There are many ways <strong>to link an input to a list of suggestions</strong>. The simple example above could have also been made with the following markup, which provides a nice native fallback in case the script doesn’t load:</p>

<pre class="language-markup"><code>&lt;input class="awesomplete" list="mylist" />
Expand Down