fix incompatibility to v1. $.ready(function() {}) used to work. #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeaVerou
reviewed
Apr 19, 2024
| @@ -3,7 +3,7 @@ import bind from "./bind.js"; | |||
|
|
|||
| function delegate (subject, type, selector, callback) { | |||
| bind(subject, type, function(evt) { | |||
| if (evt.target.closest(selector)) { | |||
| if ((evt.target.closest ? evt.target : evt.target.parentNode).closest(selector)) { | |||
There was a problem hiding this comment.
What is this change for? Any Element instance has closest, so I’m not sure what EventTarget instances there are that don’t have closest but their parents do. Even if such a node exists, this should be documented with comments because it's totally non-obvious.
LeaVerou
requested changes
Apr 19, 2024
| for (const key of Object.keys(value)) { | ||
| subject.dataset[key]=value[key] | ||
| } | ||
| } |
There was a problem hiding this comment.
Nit: Please follow the code style of the rest of the codebase (smart tabs for indentation, space around operators, etc.). I need to add an ESLint file…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bliss.ready(function() { dosomething;}) worked with v1 and should work with v2, too.
Dataset support for v2.