Bugfix: Make sure that marker appearance changes when in editing mode. #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…. Add regression tests. Fixes part of Leaflet#354 (comment).
|
This will be very nice to have back and working! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for a bug introduced by my changes in #323.
Markers were not getting the pink outline in editing mode that indicated that the marker was editable. This was because of an incorrect reference to the marker icon. I was trying to get the
_iconproperty ofthis, rather than themarker, so_toggleMarkerHighlightwas exiting early without adding the editing-style classleaflet-edit-marker-selected.I have written a quick bugfix and added two regression tests.
Thanks to @kyletolle, who identified the issue in a comment on Leaflet.draw pull request #354.