Updating to Version 11, Adding in Starfinder 5e, and Abstracting out all of the systems from the main code. #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This new setup splits out roll providers. How this works is that each system operates its own functions. Rather than having systems ingrained into the code itself, each of the systems determine if they need to override specific parts of the rolling system. This will reduce the need to check in changes to the main rolling system and allow providers to be more easily created. This also means that every system is isolated in its changes to the main rolling system.
roller.js was refering to the wrong roller.
Fixing reference issues with pf2e and fixing various location issues.
Adding in a sw5e override to create5eAbilities that fixes the reference issue.
References have been fixed on CD, but I don't know how the roll system works for CD. I attempted a fix, but there's something weird. It needs to be fixed, but I need someone who knows the CD code to fix the rolling part of this.
Updating documentation to represent what's going on.
Pf2e now rolls the correct statistic.
This was referenced Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a major refactor that pulls out all of the system-specific code out of the module itself. All system-specific code is now relegated to the RollProvider set for it, and uses custom overrides to represent the weirdness that might need to be done for each system.
I have also added in Starfinder 1st Edition, and updated the .md files to reflect the changes I have made.
This should make the code easier to read as well as easier to manage at the system level.
I did a confirmation of dnd5e, pf1, pf2e, D35E, sw5e, cof, coc, ose, degenesis, and sfrpg by testing on my Foundry server.
This upgrade will make this version verified compatible with the latest version of Foundry (v11.307)