Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deviation in the BBC functionality between (at least) LearnLib 0.14.0 and 0.16.0 #46

Closed
MasWag opened this issue Aug 20, 2021 · 2 comments

Comments

@MasWag
Copy link
Contributor

MasWag commented Aug 20, 2021

Due to the update of AbstractLTSminMonitorMealy in 75b1987, the behavior of the BBC functionality in LearnLib changed (at least) between 0.14.0 and 0.16.0. (Sorry, I have not tried 0.15.0) I believe that the previous behavior is the expected one.

Here is a concrete example to reproduce this deviation + a summary of the reason for the deviation in my understanding: https://github.com/MasWag/deviation-LearnLib-0.14.0-vs-0.16.0

mtf90 added a commit that referenced this issue Aug 21, 2021
mtf90 added a commit to LearnLib/learnlib that referenced this issue Aug 21, 2021
to check the problems reported in LearnLib/automatalib#46
@mtf90
Copy link
Member

mtf90 commented Aug 21, 2021

Dear @MasWag,

thanks for reporting this issue and providing a testcase for reproducing it. You are right, this has been a regression in one of our refactorings to better handle null values. Unfortunately, the current implementation is not really in line with the interface definitions (see here as well) and we need to clean this up some time in the future.

I have added some test-cases in LearnLib (including the use-case you have described in your repo) so that we hopefully won't break things again.

I am currently a little bit busy with some side-projects. Can you live with using the 0.14 version or the current development version for now?

@mtf90 mtf90 closed this as completed Aug 21, 2021
@MasWag
Copy link
Contributor Author

MasWag commented Aug 22, 2021

Thanks a lot for your quick response. Yes, I will keep using LearnLib 0.14 for the time being.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants