Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: CompactMealy clone constructor #50

Merged
merged 3 commits into from
Jun 16, 2022
Merged

feat: CompactMealy clone constructor #50

merged 3 commits into from
Jun 16, 2022

Conversation

tiferrei
Copy link
Contributor

Hi there,

I recently needed this functionality, so thought I'd make a PR to upstream the change. Please let me know if there's a better / preferred way of doing this.

Thanks!

@mtf90
Copy link
Member

mtf90 commented Jun 15, 2022

Hi @tiferrei, looks like a nice little convenience function. However, do you need the CompactMealy(Alphabet<I> alphabet, CompactMealy<I, O> other) constructor to be public? In the corresponding CompactDFA case this constructor is protected because it can potentially cause some issues if the alphabets don't match (it is only used by the translate method).

@tiferrei
Copy link
Contributor Author

Ah good catch! I do not indeed, I only copied it (badly), I will fix that.

@mtf90 mtf90 merged commit e7ab40f into LearnLib:develop Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants