Create states from AUT header #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtf90
reviewed
Jun 29, 2022
serialization/aut/src/main/java/net/automatalib/serialization/aut/InternalAUTParser.java
Show resolved
Hide resolved
mtf90
reviewed
Jun 29, 2022
serialization/aut/src/main/java/net/automatalib/serialization/aut/InternalAUTParser.java
Outdated
Show resolved
Hide resolved
mtf90
requested changes
Jun 29, 2022
Thank you! I've gone through and made the requested changes, and I also added some more informative exception messages for negative numbers and non-number state values. Let me know if there's anything else I can do! |
mtf90
requested changes
Jun 30, 2022
serialization/aut/src/main/java/net/automatalib/serialization/aut/InternalAUTParser.java
Outdated
Show resolved
Hide resolved
mtf90
approved these changes
Jun 30, 2022
|
There appear to be some minor validation errors left (mainly formatting, etc.). You can run the checks yourself by activating the code-analysis profile ( |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #51
Parses the number of states from the AUT header and uses the specified number of states in creating the output automaton.
Added test to ensure that AUT files with sink states (no outgoing transitions) are correctly parsed.