Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IO Continue RX flag and sync RAPDU sending #529

Merged
merged 2 commits into from
Feb 9, 2024

Conversation

xchapron-ledger
Copy link
Contributor

Description

os_io_seproxyhal: Introduce new IO_RECEIVE_DATA flag for io_exchange()
lib_standard_app/io.c: Send RAPDU immediately and use IO_CONTINUE_RX flag

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Tests
  • Documentation
  • Other (for changes that might not fit in any category)

@xchapron-ledger xchapron-ledger changed the title Xch/io continue rx IO Continue RX flag and sync RAPDU sending Feb 7, 2024
@codecov-commenter
Copy link

codecov-commenter commented Feb 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8dd9234) 60.42% compared to head (e255f0f) 60.42%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #529   +/-   ##
=======================================
  Coverage   60.42%   60.42%           
=======================================
  Files          12       12           
  Lines        1660     1660           
=======================================
  Hits         1003     1003           
  Misses        657      657           
Flag Coverage Δ
unittests 60.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xchapron-ledger xchapron-ledger merged commit 158f76d into master Feb 9, 2024
161 checks passed
@xchapron-ledger xchapron-ledger deleted the xch/IO_CONTINUE_RX branch February 9, 2024 10:02
@xchapron-ledger xchapron-ledger mentioned this pull request Feb 20, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants